fix(GRANITE-38030): Using private browser window would intermittently… #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not show the pop up context menu
github-actions bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
## [4.12.7](v4.12.6...v4.12.7) (2022-02-14) ### Bug Fixes * **GRANITE-38030:** Using private browser window would intermittently not show the pop up context menu ([#202](#202)) ([d648031](d648031))
|
🎉 This PR is included in version 4.12.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… not show the pop up context menu
Sometimes in cardview, quickactions does not show up for some items. On checking it was found that in some cases accessibilityState element in getting appended before the quickaction mutation happen. We have delayed the appending on accessiblityState element in next tick of setTimeout to ensure its the last item added.
Description
We are appending the accessibilityState element in next tick of setTImeout to ensure that it is the last added element and should be appended after quickactions mutations.
Related Issue
GRANITE-38030 : Using private browser window would intermittently not show the pop up context menu
Motivation and Context
How Has This Been Tested?
This has been tested visually.
Screenshots (if appropriate):
Types of changes
Checklist: