Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CQ-4341758): intermittently columnview does not allow selection #207

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix(CQ-4341758): intermittently columnview does not allow selection #207

merged 1 commit into from
Mar 7, 2022

Conversation

Pareesh
Copy link
Collaborator

@Pareesh Pareesh commented Mar 7, 2022

When using columnview components, it has been observed that intermittently it may not allow users to select a page. Specifically when loaded with horizontal scrollbar.

Description

When columnview is loaded with horizontal scrollbar, if select an item the column is scrolled into view but scrollcallback was not getting called. This was because it was not passed when recursion scrollTo call was made.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Pareesh Pareesh added the bug Something isn't working label Mar 7, 2022
@Pareesh Pareesh merged commit e205367 into adobe:master Mar 7, 2022
github-actions bot pushed a commit that referenced this pull request Mar 7, 2022
## [4.12.9](v4.12.8...v4.12.9) (2022-03-07)

### Bug Fixes

* **CQ-4341758:** intermittently columnview does not allow selection ([#207](#207)) ([e205367](e205367))
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

🎉 This PR is included in version 4.12.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant