fix(GRANITE-36119): Asset selection checkbox doesn't appear for all the assets in list view #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
reviewed
Mar 22, 2022
…he assets in list view
…he assets in list view
majornista
approved these changes
Mar 28, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
## [4.12.11](v4.12.10...v4.12.11) (2022-03-29) ### Bug Fixes * **GRANITE-36119:** Asset selection checkbox doesn't appear for all the assets in list view ([#209](#209)) ([fa723c5](fa723c5))
|
🎉 This PR is included in version 4.12.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes while loading the tableview, checkbox doesn't appear. This could be related to the fact that we disable the observer while loading the table template and as result the record might been dropping or the mutation might not be recorded as the observer is again set to on while body is appended. In some cases body mutation happens after the table has rendered as a result the already attached row are not correctly initialised.
Description
When handling the mutation for body, we need take into account the addition of body element and the rows it currently contains. This way we can ensure the correct initialisation of all row element.
Related Issue
GRANITE-36119
Motivation and Context
How Has This Been Tested?
Since this is a intermittent issue, we have tested it visually. The issue seems to be frequent in safari.
Screenshots (if appropriate):
Types of changes
Checklist: