fix(ASSETS-6857): Set the tabindex attribute of calendar button according to the disabled attribute value #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed attribute value
Pareesh
approved these changes
Aug 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
## [4.14.5](v4.14.4...v4.14.5) (2022-08-30) ### Bug Fixes * **ASSETS-6857:** Set the tabindex attribute of calendar button according to the disabled attribute value ([#232](#232)) ([6f3ab89](6f3ab89))
|
🎉 This PR is included in version 4.14.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A keyboard user is unable to tab to the calendar button.
A keyboard user should be able to tab to the calendar button, and the element should be announced as a button.
@review @Pareesh @RitwikSrivastava
Description
Set the tabindex attribute of calendar button according to the disabled attribute value.
Related Issue
https://jira.corp.adobe.com/browse/ASSETS-6857
Motivation and Context
A keyboard user should be able to tab to the calendar button, and the element should be announced as a button.
How Has This Been Tested?
By tabbing through the asset manage publication page and by checking if tabindex attribute of calendar button is "-1" when disabled and "0" when is not disabled.
Screenshots (if appropriate):
Types of changes
Checklist: