fix(ASSETS-6863): Files: Asset information - IPTC tab - Certain ARIA roles must contain particular children #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BogdanMare , |
Pareesh
approved these changes
Sep 15, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
## [4.15.1](v4.15.0...v4.15.1) (2022-09-15) ### Bug Fixes * **ASSETS-6863:** Files: Asset information - IPTC tab - Certain ARIA roles must contain particular children ([#239](#239)) ([9bb6f17](9bb6f17))
|
🎉 This PR is included in version 4.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "Keywords" region does not contain any input fields, consider removing the role="list" attribute from the element.
As the "Add" button is pressed and the input fields (which contain the expected role="listitem") appear, consider using JavaScript to add role="list" back to the element.
@review @Pareesh @RitwikSrivastava
Description
Handle role list attribute according to the number of items.
When coral-multifield list of items is empty, the role should change.
Related Issue
https://jira.corp.adobe.com/browse/ASSETS-6863
Motivation and Context
Only when the list of items is not empty should have the role list attribute added.
How Has This Been Tested?
By adding and removing items.
Screenshots (if appropriate):
Types of changes
Checklist: