Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ASSETS-6927):Upon invoking the “Add” button present in the page, focus is not shifted to the newly identified field. #252

Conversation

ionelc-ensemble
Copy link
Contributor

@ionelc-ensemble ionelc-ensemble commented Oct 14, 2022

After adding a new input, switch focus to it immediately.

Description

Related Issue

Motivation and Context

https://jira.corp.adobe.com/browse/ASSETS-6927

How Has This Been Tested?

Tested manually on local AEM instance in Chrome 106 on macOS 12.6

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@ionelc-ensemble ionelc-ensemble marked this pull request as ready for review October 17, 2022 11:50
@ionelc-ensemble
Copy link
Contributor Author

@Pareesh @RitwikSrivastava this is ready for reviewing (I cannot add reviewers)

@RitwikSrivastava
Copy link
Contributor

@majornista Can you please review this ?

@ionelc-ensemble
Copy link
Contributor Author

@majornista thanks for review & approval. If possible, please merge or merge & release

@majornista majornista merged commit 54839bc into adobe:master Jan 18, 2023
majornista pushed a commit that referenced this pull request Jan 18, 2023
… focus is not shifted to the newly identified field. (#252)

* shift focus to newly added input

* update child selector

* refactor & fix tests

* update input selector

* handle unfocusable elements

* clean up

* rename variables

* focus the add btn if new item is disabled
github-actions bot pushed a commit that referenced this pull request Jan 18, 2023
## [4.15.10](v4.15.9...v4.15.10) (2023-01-18)

### Bug Fixes

* **ASSETS-6927:** Upon invoking the “Add” button present in the page, focus is not shifted to the newly identified field. ([#252](#252)) ([a1c9593](a1c9593))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants