fix(ASSETS-5344):[Supporting the Platforms-AEM Dynamic Media-Edit Smart Crops]: In High Contrast Black and White modes, 'Image View' slider is not visible which is present in the 'Edit Smart Crops'. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pareesh and @RitwikSrivastava this is ready for review. |
|
cc @majornista |
Pareesh
approved these changes
Nov 2, 2022
Pareesh
approved these changes
Nov 2, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
## [4.15.5](v4.15.4...v4.15.5) (2022-11-02) ### Bug Fixes * **ASSETS-5344:** slider track visibility in windows high contrast modes ([#254](#254)) ([07f5793](07f5793))
|
🎉 This PR is included in version 4.15.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/ASSETS-5344
Description
Slider track is not visible in Windows if a High Contrast mode is enabled in the OS settings because the element only has background color which is removed by the OS High Contrast settings.
Fixed by setting the tracker height to 0 and adding a 1px solid border around it when contrast mode is enabled.
Screenshots added below.
Related Issue
Motivation and Context
How Has This Been Tested?
Manually tested in latest version of Edge (v106.0), Chrome (v106.0) and Firefox (v106.0.2) on Windows 10 v21h2 in all the default High Contrast modes
Screenshots (if appropriate):
Types of changes
Checklist: