Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GRANITE-42603): Multifield component does not provide support for readonly #257

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Conversation

Pareesh
Copy link
Collaborator

@Pareesh Pareesh commented Nov 7, 2022

The current multifield implementation does not support readonly. Added a support for the same.

Description

Added a getter/setter property for readonly in multifield component. Setting this value will make the multifield component readonly and unsetting or default value will make it editable.

@review @hparwani2

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Pareesh Pareesh changed the title fix(GRANITE-42603): Disable Edit for Multivalued Text Field in Metada… fix(GRANITE-42603): Multifield component does not provide support for readonly Nov 7, 2022
@Pareesh Pareesh merged commit 952936f into adobe:master Nov 29, 2022
github-actions bot pushed a commit that referenced this pull request Dec 1, 2022
## [4.15.8](v4.15.7...v4.15.8) (2022-12-01)

### Bug Fixes

* Correct build ([#266](#266)) ([0e7e535](0e7e535))
* **GRANITE-42603:** Multifield component does not provide support for readonly ([#257](#257)) ([952936f](952936f))
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

🎉 This PR is included in version 4.15.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

hparwani2 pushed a commit to hparwani2/coral-spectrum that referenced this pull request Dec 8, 2022
## [4.15.8](adobe/coral-spectrum@v4.15.7...v4.15.8) (2022-12-01)

### Bug Fixes

* Correct build ([adobe#266](adobe#266)) ([0e7e535](adobe@0e7e535))
* **GRANITE-42603:** Multifield component does not provide support for readonly ([adobe#257](adobe#257)) ([952936f](adobe@952936f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants