fix(ASSETS-17260): State of active component lacks 3 to 1 contrast ratio #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MarianGiurge , |
Pareesh
reviewed
Apr 28, 2023
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| ._coral-Table-cell { | |||
| background-color: $table-background-color; | |||
| color: $table-cell-color; | |||
| color: #222222; | |||
There was a problem hiding this comment.
please use variables for color or rgba, this goes for below changes as well.
|
first image is before the change and second image is after the change |
Pareesh
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2023
## [4.15.17](v4.15.16...v4.15.17) (2023-05-04) ### Bug Fixes * **ASSETS-17260:** State of active component lacks 3 to 1 contrast ratio ([#290](#290)) ([f6596a6](f6596a6))
|
🎉 This PR is included in version 4.15.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/ASSETS-17260
Description
raised contrast ratio
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: