Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accessibility): State of active component lacks 3 to 1 contrast ratio. #299

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

RazvanPRA
Copy link
Contributor

@RazvanPRA RazvanPRA commented Jun 15, 2023

https://jira.corp.adobe.com/browse/SITES-10905

https://git.corp.adobe.com/Granite/com.adobe.granite.ui.coral-spectrum/pull/163

With this change, I fixed the contrast issue

Before:
Screenshot 2023-06-15 at 09 43 44
Screenshot 2023-06-15 at 09 42 55

After:
Screenshot 2023-06-15 at 09 14 41
Screenshot 2023-06-15 at 09 13 19

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Pareesh Pareesh changed the title SITES-10905 State of active component lacks 3 to 1 contrast ratio. fix(accessibility): State of active component lacks 3 to 1 contrast ratio. Jun 19, 2023
@Pareesh Pareesh merged commit 734bff1 into master Jun 19, 2023
2 checks passed
@Pareesh Pareesh deleted the SITES-10905 branch June 19, 2023 08:07
github-actions bot pushed a commit that referenced this pull request Jun 19, 2023
## [4.15.19](v4.15.18...v4.15.19) (2023-06-19)

### Bug Fixes

* **accessibility:** State of active component lacks 3 to 1 contrast ratio ([#299](#299)) ([734bff1](734bff1))
@github-actions
Copy link

🎉 This PR is included in version 4.15.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants