Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): Shell header menu is being cut off #301

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

RazvanPRA
Copy link
Contributor

@RazvanPRA RazvanPRA commented Jun 15, 2023

https://jira.corp.adobe.com/browse/SITES-14128

With this change, I solved the issue mentioned in the ticket and the style was added according to SITES-2855. (https://jira.corp.adobe.com/browse/SITES-2855)

Before:

246131606-6ae4d3c6-a474-485a-918a-92f1b3b0baef
246131632-7fc62a87-6834-43e0-bc62-54cf68472d3f

After:

246130785-006bc1bb-9f10-4ad9-a1f4-a2f4d650a187 246130805-24d09556-b20d-482f-9e66-30b6023a6c54

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Pareesh
Copy link
Collaborator

Pareesh commented Jun 19, 2023

Hi @RazvanPRA ,
The second picture attached in this PR, kindly please attach how is it looking after the fix. In that image, it looks like many things are overlapping,

@RazvanPRA
Copy link
Contributor Author

RazvanPRA commented Jun 20, 2023

Hello @Pareesh ,
This Issue mentioned is no longer current, it is being solved by another ticket from the past, the fourth image shows this

@RazvanPRA
Copy link
Contributor Author

Hello @Pareesh , I need approval for this PR, please!

@RazvanPRA RazvanPRA requested a review from Pareesh July 7, 2023 08:08
@Pareesh Pareesh changed the title SITES-14128 The menu in the top right of assets UI is cut off in AEMCS fix(bug): Shell header menu is being cut off Jul 10, 2023
@Pareesh Pareesh merged commit 299ba4a into adobe:master Jul 10, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
## [4.15.21](v4.15.20...v4.15.21) (2023-07-12)

### Bug Fixes

* **Accessibility:** Focus is not visible on dropdown elements in high contrast ([#304](#304)) ([cde7c68](cde7c68))
* ActionBar items moves focus to disabled items. ([#302](#302)) ([fae0821](fae0821))
* **bug:** Shell header menu is being cut off ([#301](#301)) ([299ba4a](299ba4a))
@github-actions
Copy link

🎉 This PR is included in version 4.15.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants