Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the role to alert for success toast #307

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

mariang-ens
Copy link
Contributor

@mariang-ens mariang-ens commented Jul 18, 2023

https://jira.corp.adobe.com/browse/ASSETS-25755

Description

Updated to use role="alert" to enforce screen reader announcement.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@mariang-ens mariang-ens changed the title fix: Update the role to alert for success toast ASSETS-25755 - fix: Update the role to alert for success toast Jul 24, 2023
@Pareesh Pareesh changed the title ASSETS-25755 - fix: Update the role to alert for success toast fix: Update the role to alert for success toast Aug 18, 2023
@Pareesh Pareesh merged commit 4db63d6 into adobe:master Aug 18, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 18, 2023
## [4.15.23](v4.15.22...v4.15.23) (2023-08-18)

### Bug Fixes

* Update the role to alert for success toast ([#307](#307)) ([4db63d6](4db63d6))
@github-actions
Copy link

🎉 This PR is included in version 4.15.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants