Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension keys must be tied to explicit versions #46

Open
purplecabbage opened this issue Jan 12, 2024 · 2 comments
Open

extension keys must be tied to explicit versions #46

purplecabbage opened this issue Jan 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@purplecabbage
Copy link
Member

purplecabbage commented Jan 12, 2024

Description

This command was broken by publishing a new latest version of this module, even though it was a major version.

aio app:init --no-login -i ../../test/console.json -e dx/asset-compute/worker/1

dx/asset-compute/worker/1 used to mean @adobe/generator-app-asset-compute@1.0.2

but now it results in:
@adobe/generator-app-asset-compute@2 which may not be compatible.

Workaround

Use:
--template @adobe/generator-app-asset-compute@1.0.2 instead of the --extension flag.

Fix

We need to decide if a new major of a template generator should also mean a new extension registry key.
Should
dx/asset-compute/worker/1 => @adobe/generator-app-asset-compute@1
and
dx/asset-compute/worker/2 => @adobe/generator-app-asset-compute@2

@purplecabbage purplecabbage added the bug Something isn't working label Jan 12, 2024
@aiojbot
Copy link

aiojbot commented Jan 13, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2721

@shazron
Copy link
Member

shazron commented Jan 25, 2024

We can possibly also fix it in the Template Registry. By design the Template Registry always checks daily for the latest version of a template and updates it in the registry. We would have to propose a new feature somehow tying extension points to certain template versions -- there is no way to do this right now via the standard mechanisms.

Since the Template Registry version check is via the latest dist-tag on npm (via npm view PACKAGE_NAME version), we could always point to v1.0.2 as latest for now until we get it sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants