Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "heading to id= attribute" behavior #538

Open
davidnuescheler opened this issue Feb 14, 2024 · 2 comments
Open

remove "heading to id= attribute" behavior #538

davidnuescheler opened this issue Feb 14, 2024 · 2 comments
Labels
question Further information is requested

Comments

@davidnuescheler
Copy link

currently we are using a common pattern that translates headings to id= attributes so they can be addressed via # fragments.

i think this is not very practical in most website use cases as there is a stability requirement, so author control (mostly on sections instead of headings) is really much more desirable. also it seems that since the current behavior could easily be implemented client sided if needed it feels like extra markup that doesn't need to be transmitted.

i appreciate that proposing this change is a breaking change, but i think it could be great if we started to transition to that possibly by removing the id attributes in aem.js to make sure that projects stop relying on it.

@davidnuescheler davidnuescheler added the question Further information is requested label Feb 14, 2024
@trieloff
Copy link
Contributor

Stripping it in aem.js seems sensible.

@docs-dre
Copy link

docs-dre commented Apr 5, 2024

hi @davidnuescheler - I was wondering if theres any progress made on this ticket? I am getting continued asks about this feature on my end as we would like to have the ability to anchor to a non heading (i.e anchor to any section of the page or even a block). https://jira.corp.adobe.com/browse/MWPW-141652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants