Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly escape tilde #190

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix: properly escape tilde #190

merged 1 commit into from
Aug 2, 2023

Conversation

tripodsan
Copy link
Contributor

@tripodsan tripodsan commented Jul 17, 2023

fixes #189

with the recent markdown libraries, the tilde doesn't need special treatment and is always escaped and parsed correctly.

@tripodsan tripodsan requested a review from kptdobe July 17, 2023 10:07
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #190 (dbb298b) into main (8a7d7f1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   95.62%   95.61%   -0.02%     
==========================================
  Files          14       14              
  Lines        1533     1528       -5     
==========================================
- Hits         1466     1461       -5     
  Misses         67       67              
Impacted Files Coverage Δ
src/utils/DOMUtils.js 94.46% <ø> (-0.10%) ⬇️
src/importer/PageImporter.js 85.83% <100.00%> (ø)
src/utils/MDUtils.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@kptdobe kptdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tripodsan!

@kptdobe kptdobe merged commit 9853f17 into main Aug 2, 2023
5 checks passed
@kptdobe kptdobe deleted the proper-tilde-escaping branch August 2, 2023 06:35
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
## [2.9.18](v2.9.17...v2.9.18) (2023-08-02)

### Bug Fixes

* properly escape tilde ([#190](#190)) ([9853f17](9853f17)), closes [#189](#189)
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This PR is included in version 2.9.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text with tilde is not properly importer
2 participants