Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: createTable handles colspans #33

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Nov 17, 2022

Currently DOMUtils.createTable does not support colspans which leads to creation of tables with empty cells. And usually the header cell is the one with only one column (block name) which is not nice looking.
This PR adds the colspan support across the full table.

@kptdobe kptdobe requested a review from mhaack November 17, 2022 14:07
@kptdobe kptdobe merged commit 06c48cf into main Nov 17, 2022
@kptdobe kptdobe deleted the createtable-handles-colspans branch November 17, 2022 14:20
github-actions bot pushed a commit that referenced this pull request Nov 17, 2022
# [2.2.0](v2.1.1...v2.2.0) (2022-11-17)

### Features

* createTable handles colspans ([#33](#33)) ([06c48cf](06c48cf))
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants