Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Preview button click seems to hang before "Please wait..." message appears #270

Closed
kptdobe opened this issue Mar 14, 2022 · 1 comment · Fixed by #269
Closed

Preview button click seems to hang before "Please wait..." message appears #270

kptdobe opened this issue Mar 14, 2022 · 1 comment · Fixed by #269
Labels
bug Something isn't working released

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Mar 14, 2022

In a gdoc, open the Sidekick and hit the Preview button: depending on the speed of the update, it feels like something is hanging for 1s, 2s, sometimes more before the "Please wait" message appears. Things then go fast and the new window is opened. It really feels like the message appeared too late.

Reason is this update call:

https://github.com/adobe/helix-sidekick/blob/main/src/sidekick/module.js#L798

which happens before the modal will be shown.
@kptdobe kptdobe added the bug Something isn't working label Mar 14, 2022
@kptdobe kptdobe mentioned this issue Mar 14, 2022
Closed
@rofe rofe mentioned this issue Mar 14, 2022
Merged
@rofe rofe closed this as completed in #269 Mar 14, 2022
@trieloff
Copy link

🎉 This issue has been resolved in version 4.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@trieloff @kptdobe