Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Prevent preview update if webPath is undefined #286

Closed
rofe opened this issue Mar 31, 2022 · 1 comment · Fixed by #287
Closed

Prevent preview update if webPath is undefined #286

rofe opened this issue Mar 31, 2022 · 1 comment · Fixed by #287
Labels
bug Something isn't working released

Comments

@rofe
Copy link
Contributor

rofe commented Mar 31, 2022

If status.webPath is undefined (maybe due to a timeout while fetching the status), the sidekick should not allow updating the preview since the POST would fail.
@rofe rofe added the bug Something isn't working label Mar 31, 2022
@rofe rofe mentioned this issue Mar 31, 2022
Merged
@rofe rofe closed this as completed in #287 Mar 31, 2022
@trieloff
Copy link

🎉 This issue has been resolved in version 4.9.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent preview update if webPath undefined adobe/helix-sidekick
2 participants
@trieloff @rofe