Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

http2 request to typekit might cause errors #351

Closed
tripodsan opened this issue Jul 14, 2020 · 3 comments
Closed

http2 request to typekit might cause errors #351

tripodsan opened this issue Jul 14, 2020 · 3 comments
Assignees
@stefan-guggisberg

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Jul 14, 2020 •
edited

Requesting https://theblog-adobe.hlx.page/hlx_fonts/pnv6nym.css causes a 504.

see https://dashboard.epsagon.com/spans/0e80f2c1-5971-6659-4081-2282a1b3498f

image
@tripodsan tripodsan self-assigned this Jul 14, 2020
@tripodsan
Copy link
Contributor Author

tripodsan commented Jul 14, 2020 •
edited

After a re-deploy of the action the requests work again. Since the fetch-context is kept globally for all activations, one cause could be that it accidentally reused a closed session.

a potential (suboptimal) solution could be to obtain a context for every invocation and destroy the connections afterwards.

@stefan-guggisberg WDYT?

@tripodsan tripodsan removed their assignment Jul 14, 2020
@tripodsan tripodsan mentioned this issue Jul 14, 2020
Merged
@tripodsan tripodsan mentioned this issue Oct 29, 2020
Closed
@tripodsan
Copy link
Contributor Author

also see adobe/fetch#103

@stefan-guggisberg stefan-guggisberg self-assigned this Dec 9, 2020
@stefan-guggisberg
Copy link
Contributor

fixed in 9b1ecc7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stefan-guggisberg stefan-guggisberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tripodsan @stefan-guggisberg