useTextField mutates onChange behavior internally

[csantos1113]

🐛 Bug Report

I was debating myself if this should be reported as a bug or as a question (given that this code it's been there since 2+ years ago), but decided to go with the Bug route:

useTextField is overwriting the onChange behavior by deciding to send e.target.value as the prop instead of sending the entire SyntheticEvent object.

https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/textfield/src/useTextField.ts#L80

onChange: (e: ChangeEvent<HTMLInputElement>) => onChange(e.target.value)

Why do I think this is a bug?
Literally any other event handler (onCopy, onCut, onSelect, onInput, etc, etc) is passed down without any modifications, see: https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/textfield/src/useTextField.ts#L88-L105

See, React SyntheticEvent: https://reactjs.org/docs/events.html#form-events

🤔 Expected Behavior

onChange to not have custom logic and to be passed down straight to the input

😯 Current Behavior

onChange is called with the raw value of the input when all other event handlers (ex: onInput) are called with the SyntheticEvent object.

💁 Possible Solution

Change

onChange: (e: ChangeEvent<HTMLInputElement>) => onChange(e.target.value)

to

onChange: props.onChange

Yes, I understand this would be breaking change :/ - (Sorry, I don't understand why this wasn't raised long ago)

🔦 Context

I'm trying to integrate an external library (react-hook-form) that gives me a onChange handler that is expected to receive a SyntheticEvent but it fails badly because this hook calls onChange fn with the raw value.

💻 Code Sample

This example does not integrate with react-hook-form, but showcases the different values we get on onChange vs other event handlers
https://codesandbox.io/s/optimistic-hofstadter-4zg5o?file=/src/App.js

🌍 Your Environment

Software	Version(s)
@react-aria/textfield	3.3.1
Browser	All
Operating System	All

[devongovett]

Please see #1860 (comment) and related discussion.

[LFDanLu]

Closing for now, feel free to reopen if you have further questions or concerns.