Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IllustratedMessage uses Italics font-style for CCJK #4165

Closed
lreis opened this issue Mar 6, 2023 · 2 comments 路 Fixed by #4238
Closed

IllustratedMessage uses Italics font-style for CCJK #4165

lreis opened this issue Mar 6, 2023 · 2 comments 路 Fixed by #4238
Assignees
@ktabors
Labels
bug Something isn't working

Comments

@lreis
Copy link
Contributor

lreis commented Mar 6, 2023 •
edited

馃悰 Bug Report

The IllustratedMessage component applies Italics to its body text when using a Content child component, for all locales.

馃 Expected Behavior

The Italics font-style is not used for CCJK, since that style is not appropriate in those languages.

馃槸 Current Behavior

The Italics font-style is used for CCJK.

rspv3-illustrated-message-italics

馃拋 Possible Solution

Investigate font handling for CCJK locales.

馃敠 Context

See also #4125

馃捇 Code Sample

React-Spectrum v3 Storybook

馃Б Your Company/Team

Adobe Localization
@LFDanLu LFDanLu added the bug Something isn't working label Mar 6, 2023
@LFDanLu
Copy link
Member

LFDanLu commented Mar 8, 2023

Look into applying font-synthesis: none to get rid of the italics

@devongovett
Copy link
Member

Maybe in here: https://github.com/adobe/react-spectrum/blob/main/packages/%40adobe/spectrum-css-temp/components/commons/fonts.css

@ktabors ktabors mentioned this issue Mar 21, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktabors ktabors

Labels
bug Something isn't working
Projects
RSP Component Milestones
Archived in project
Milestone
No milestone
4 participants
@devongovett @ktabors @lreis @LFDanLu