Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] ComboBox does not set data-focus-visible or data-hovered attributes #5974

Open
vbudovski opened this issue Feb 29, 2024 · 1 comment
Open

Comments

@vbudovski
Copy link

Provide a general summary of the issue here

RAC ComboBox does not set ComboBox does not set data-focus-visible or data-hovered attributes. This makes it difficult to set styling on keyboard focus and hover. I can work around it using the hover state of the button and input. Using the data-focused attribute instead of data-focus-visible can be an option, but only if you don't require distinct states for styling.

🤔 Expected Behavior?

ComboBox sets the data-focus-visible and data-hovered attributes when appropriate.

😯 Current Behavior

ComboBox does not set the data-focus-visible or data-hovered attributes.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://react-spectrum.adobe.com/react-aria/ComboBox.html#example

Version

RAC 1.1.1

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Mac OS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@LFDanLu
Copy link
Member

LFDanLu commented Mar 1, 2024

Thanks for catching this, the team had initially considered adding this in the earlier iterations of RAC but pulled it out. We are revisiting this though since we may have scrapped/forgot to add in a wrapper that would've substituted for those top level data attributes. Will update you once we come up with a final approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants