Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section does not apply aria label #6422

Closed
Shadowlauch opened this issue May 21, 2024 · 1 comment · Fixed by #6423
Closed

Section does not apply aria label #6422

Shadowlauch opened this issue May 21, 2024 · 1 comment · Fixed by #6423
Labels
accessibility bug Something isn't working

Comments

@Shadowlauch
Copy link

Provide a general summary of the issue here

I was following the steps laid out in https://react-spectrum.adobe.com/react-aria/Menu.html#section and added an aria-label to the section, but this label is not actually applied to the dom.

🤔 Expected Behavior?

I would expect the aria-label that was handed into the Section to be applied to the dom

😯 Current Behavior

The aria-label that was handed into the Section is not applied to the dom

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/magical-sun-fty327

Version

3.31.0

What browsers are you seeing the problem on?

Firefox, Chrome

If other, please specify.

No response

What operating system are you using?

Mac

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@snowystinger
Copy link
Member

Thanks for reporting this, it looks like this line has a typo

'aria-label': section['aria-label'] ?? undefined

'aria-label': section['aria-label'] ?? undefined
// should be
'aria-label': section.props['aria-label'] ?? undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants