Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiddenSelect should be disabled when Picker is disabled #786

Closed
devongovett opened this issue Jul 18, 2020 · 1 comment 路 Fixed by #787
Closed

HiddenSelect should be disabled when Picker is disabled #786

devongovett opened this issue Jul 18, 2020 · 1 comment 路 Fixed by #787
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@devongovett
Copy link
Member

馃悰 Bug Report

Noticed that the HiddenSelect component inside a Picker is not disabled when Picker is disabled. This means the <select> and <input> elements are still enabled, and the <input> still accepts focus which messes up tabbing around the page.

馃拋 Possible Solution

Pass isDisabled prop through to HiddenSelect and make both the <select> and <input> disabled when it is true.

馃敠 Context

Noticed when testing in this CodeSandbox. There's an extra tab stop after the enabled picker before the next enabled button that shouldn't be there. Inspecting the DOM shows that the <input> inside the disabled picker has focus.

馃實 Your Environment

Software Version(s)
react-spectrum 3.0.2
Browser Chrome
Operating System macOS

馃Б Your Company/Team

RSP

@devongovett devongovett added bug Something isn't working good first issue Good for newcomers labels Jul 18, 2020
@gavinhenderson
Copy link
Contributor

Ill grab this if thats alright 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants