Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get everything running on Windows #796

Closed
snowystinger opened this issue Jul 20, 2020 · 4 comments 路 Fixed by #805
Closed

Get everything running on Windows #796

snowystinger opened this issue Jul 20, 2020 · 4 comments 路 Fixed by #805
Labels
good first issue Good for newcomers

Comments

@snowystinger
Copy link
Member

snowystinger commented Jul 20, 2020

馃檵 Feature Request

Get all of our commands working on windows. This is probably easiest for someone with a windows machine to do.

馃 Expected Behavior

馃槸 Current Behavior

Current behavior has some problems, a few are seen in this issue. There are probably some more, check all the other commands.
#782

馃拋 Possible Solution

馃敠 Context

馃捇 Examples

馃Б Your Company/Team

馃巵 Tracking Ticket (optional)

@mischnic mischnic added the good first issue Good for newcomers label Jul 20, 2020
@devongovett
Copy link
Member

This might mean replacing make? I don't believe it works out of the box on windows. Maybe with WSL but not sure if we can require that.

@snowystinger
Copy link
Member Author

A few of our package scripts don't use make anyways, and a few of our make targets must be directly invoked, I'm all for being more consistent on that front

@devongovett
Copy link
Member

A bunch of the npm scripts just call make under the hood though

@snowystinger
Copy link
Member Author

yeah, my comment is more about
yarn install
yarn start
but
make clean_all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants