Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[progressbar]: add support for variable width #497

Closed
snowystinger opened this issue Jan 23, 2020 · 7 comments
Closed

[progressbar]: add support for variable width #497

snowystinger opened this issue Jan 23, 2020 · 7 comments
Labels
ask design Questions or topics for the design team blocked See description and comments for what is blocking this issue sync to jira These will be pushed into adobe internal jira

Comments

@snowystinger
Copy link
Member

snowystinger commented Jan 23, 2020

Description

Bar loaders should support any width. It seems like we could specify all sub parts as percentages.

Why do you need this feature or component?

Someone asked how to do this with an indeterminate loader and was given the response that they must create their own styles and keyframes.

Additional context

I'm not sure if this is intentional, if so, then we should probably document it on the spectrum site or here.

synced to jira: https://jira.corp.adobe.com/browse/CSS-132

@snowystinger snowystinger changed the title Bar loaders of any size Bar loaders of any width Jan 23, 2020
@GarthDB
Copy link
Member

GarthDB commented Jan 29, 2020

@badimon says that there's no real reason to not allow it to be flexible, but I'll need to dig into the indeterminate keyframes and styles. @snowystinger do you have any specific use cases I could use to test out a different width?

@snowystinger
Copy link
Member Author

snowystinger commented Jan 29, 2020

@GarthDB I do not know, but the conversation was here https://adobe.slack.com/archives/C7N5BE1EW/p1579716339061800

@GarthDB
Copy link
Member

GarthDB commented Feb 3, 2020

An example that seems to be doing it with just right and left properties https://codepen.io/holdencreative/pen/vEVbwv

@snowystinger
Copy link
Member Author

snowystinger commented Jun 5, 2020

FYI, just got back from a dive into css animation performance, we probably don't want to use left/right, it's apparently a general no no
still randomly thinking about this one, maybe something along these lines instead so we can take advantage of translateX
https://jsfiddle.net/snowystinger/r1t76cwv/1/

or constant fill size but variable bar size https://jsfiddle.net/snowystinger/fpzxk6s7/2/

@misterbrownlee misterbrownlee added blocked See description and comments for what is blocking this issue and removed blocked by Design labels Aug 24, 2020
@misterbrownlee misterbrownlee added the ask design Questions or topics for the design team label Apr 11, 2022
@misterbrownlee misterbrownlee added the sync to jira These will be pushed into adobe internal jira label May 9, 2022
@castastrophe castastrophe changed the title Bar loaders of any width [progressbar]: add support for variable width Mar 6, 2023
@castastrophe
Copy link
Collaborator

@pfulton Do you know if this is still an outstanding question or has this issue been resolved during our rework of the component?

@pfulton
Copy link
Collaborator

pfulton commented Nov 13, 2023

@castastrophe with the new tokens definition, it looks like Design has specified that this component should have min and max width values: (see here in Spectrum Tokens)—but, we do make --mod-* prefixed overrides available for this, so if folks wanted to customize it, they could.

I don't know if that fully addresses the topic of conversation here, but it's an answer!

@castastrophe
Copy link
Collaborator

@pfulton Thank you so much! I'll close this out but @snowystinger, feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask design Questions or topics for the design team blocked See description and comments for what is blocking this issue sync to jira These will be pushed into adobe internal jira
Projects
None yet
Development

No branches or pull requests

7 participants