Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techometer reporting #137

Closed
Westbrook opened this issue Aug 15, 2019 · 2 comments · Fixed by #1635
Closed

Techometer reporting #137

Westbrook opened this issue Aug 15, 2019 · 2 comments · Fixed by #1635

Comments

@Westbrook
Copy link
Contributor

Expected Behaviour

Tachometer scoring is applied somewhere and covers a decent amount of an elements standard use cases?

Actual Behaviour

You have to run it manually.

Reproduce Scenario (including but not limited to)

npm run test:bench

Notes:

Be sure to check on things like #103 (comment) when deciding how to cover use cases.

@Westbrook
Copy link
Contributor Author

Looks like the change to have lit-html be a dependency rather than a devDependency a la https://github.com/adobe/spectrum-web-components/pull/683/files#diff-62e26ea604f25c999ecde6acf4720099R48 would allow us to leverage the --package-version flag from tachometer to compare @current to a local build of the packages, which would allow us to leverage this scoring in CI and possibly as a PR gate. Another great win for #679.

@Westbrook
Copy link
Contributor Author

With the addition of #978 we'll be able to efficiently test a local build against what's on the latest channel on NPM. Steps from there to see this completed:

  • test performance changes in CI (possibly filtering for changes similar to what the Lerna versioning code does)
  • report results into PRs
  • possibly block PRs with regressions behind an approval step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant