Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No tray behavior with sp-action-menu on Android #2575

Closed
1 task done
HenryPing opened this issue Sep 12, 2022 · 5 comments
Closed
1 task done

[Bug]: No tray behavior with sp-action-menu on Android #2575

HenryPing opened this issue Sep 12, 2022 · 5 comments

Comments

@HenryPing
Copy link

HenryPing commented Sep 12, 2022

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

ProjectX

Expected behavior

On Mobile, sp-action-menu is supposed to display its menu items within in tray from the bottom of the screen.

Actual behavior

No tray, instead, sp-action-menu display its menu items within in popover style on Android as it does on desktop. This happens in both ProjectX shell app on Android and Chrome browser on Android.

More details/discussion can be seen at this Slack thread:
https://cclight.slack.com/archives/CESK60MQD/p1662762810680189

Screenshots

Screen Shot 2022-09-12 at 3 28 58 PM

Screen Shot 2022-09-12 at 3 29 55 PM

![Uploading Screen Shot 2022-09-12 at 3.29.55 PM.png…]()

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

There are 2 ways:

  1. ProjectX on Android

    • Install and launch ProjectX shell app on Android device
    • open an existing document
    • tap the page adornment("... Page 1") at the top of the page
    • The page adornment menu items are shown as popover instead of tray, attached image 1
  2. Chrome on Android:

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@HenryPing HenryPing added bug Something isn't working triage An issue needing triage labels Sep 12, 2022
@Westbrook
Copy link
Contributor

@HenryPing have you been able to confirm this state in the context of an actual device? I'd be interested in knowing if this is failing on pointer: coarse as it seems you're on an emulator, which would mean it could read you mouse as pointer: fine... 🤔 A quick test would be to be whether the docs site loads in medium or large scale by default in this context, as it also uses roughly the same media query.

@HenryPing
Copy link
Author

HenryPing commented Sep 13, 2022

@Westbrook Yes, it is on the actual device. I used Vysor to mirror the device screen to my desktop to make it easier to take screen shot & video.

My android device info:
Samsung S21
Android version: 12
Chrome version: 105.0.5195.79

@Westbrook
Copy link
Contributor

@najikahalsema
Copy link
Collaborator

It seems like the bug was addressed per this comment on Friday. Perhaps we can test the latest version of Chromium on Android and see if this is still reproducible? @HenryPing

@Westbrook
Copy link
Contributor

Chromium/Android has since shipped updates that should normalize this delivery context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants