Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Meter component is using progressbar role instead of meter role #3155

Closed
1 task done
dineshy87 opened this issue Apr 26, 2023 · 0 comments · Fixed by #3459
Closed
1 task done

[Bug]: Meter component is using progressbar role instead of meter role #3155

dineshy87 opened this issue Apr 26, 2023 · 0 comments · Fixed by #3459
Assignees
@Rajdeepc
Labels
a11y Issues related to accessibility bug Something isn't working Component: Meter

Comments

@dineshy87
Copy link

dineshy87 commented Apr 26, 2023 •
edited

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Meter

Expected behavior

Meter component must use role="meter". (WAI-ARIA allows multiple roles to be specified as an ordered set of space-separated valid role tokens. The additional roles are fallback roles similar to the concept of specifying multiple fonts in case the first choice font type is not supported) React-Spectrum uses role="meter progressbar" as role for meter component in which case progressbar is considered a fallback option if for some reason the meter role is not recognized.

Actual behavior

Currently the sp-meter component uses role="progressbar"
@dineshy87 dineshy87 added bug Something isn't working triage An issue needing triage labels Apr 26, 2023
@dineshy87 dineshy87 changed the title [Bug]: meter component is using progressbar role instead of meter role [Bug]: Meter component is using progressbar role instead of meter role Apr 26, 2023
@najikahalsema najikahalsema added the a11y Issues related to accessibility label Jun 2, 2023
@najikahalsema najikahalsema added Component: Meter and removed triage An issue needing triage labels Jun 9, 2023
@Rajdeepc Rajdeepc self-assigned this Jul 14, 2023
@Rajdeepc Rajdeepc linked a pull request Jul 18, 2023 that will close this issue
chore(meter): added role="meter progressbar" in meter component #3459
Merged
13 tasks
@Rajdeepc Rajdeepc mentioned this issue Jul 18, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rajdeepc Rajdeepc

Labels
a11y Issues related to accessibility bug Something isn't working Component: Meter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(meter): added role="meter progressbar" in meter component adobe/spectrum-web-components
3 participants
@Rajdeepc @dineshy87 @najikahalsema