Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][a11y]: AccordionItem should not have role="listitem" #3212

Closed
1 task done
majornista opened this issue May 18, 2023 · 5 comments
Closed
1 task done

[Bug][a11y]: AccordionItem should not have role="listitem" #3212

majornista opened this issue May 18, 2023 · 5 comments
Labels
a11y Issues related to accessibility bug Something isn't working Component: Accordion Spectrum CSS Bug

Comments

@majornista
Copy link
Contributor

majornista commented May 18, 2023

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Accordion, AccordionItem

Expected behavior

sp-accordion-item should not expresses its WAI-ARIA role as a listitem.

Actual behavior

sp-accordion-item expresses its WAI-ARIA role as a listitem but the containing sp-accordion is not a list.

This seems to come from Spectrum-CSS, with:

Coming from .spectrum-Accordion-item:

https://github.com/adobe/spectrum-css/blob/e9c58caecfcfa8dd71a25d582c2394ed120e6b5e/components/accordion/index.css#L53

Screenshots

No response

What browsers are you seeing the problem in?

Chrome, Safari

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/accordion/
  2. Using Web Inspector tool, inspect the Accessibility properties for the first <sp-accordion-item> element in the first Accordion example.
  3. Notice that in the Accessibility tree, the <sp-accordion-item> is identified as having role="listitem"
  4. Using Web Inspector tool, inspect the Accessibility properties for the <sp-accordion> element that contains the <sp-accordion-item> in the first Accordion example.
  5. Notice that in the Accessibility tree, the <sp-accordion> has no role defined.

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

Related issue: Spectrum CSS Issue #1884

@majornista majornista added bug Something isn't working triage An issue needing triage labels May 18, 2023
@majornista majornista changed the title [Bug][a11y]: Accordion should use role="list" [Bug][a11y]: AccordionItem should not have role="listitem" May 18, 2023
@Westbrook Westbrook added the a11y Issues related to accessibility label Jun 2, 2023
@najikahalsema najikahalsema added Component: Accordion Spectrum CSS Bug and removed triage An issue needing triage labels Jun 9, 2023
@Rajdeepc
Copy link
Contributor

Rajdeepc commented Jun 20, 2023

Adding spectrum-css PR: adobe/spectrum-css#1789
Adding swc PR: #3300

@Rajdeepc
Copy link
Contributor

The above PR is merged. waiting for the issue to be tested.

@Rajdeepc
Copy link
Contributor

Rajdeepc commented Jul 3, 2023

@pfulton @venkateshjo Can we mark this as done from our end too?
cc @jnjosh

@venkateshjo
Copy link
Contributor

This issue is fixed in the latest swc.
we can close this issue.

@Rajdeepc
Copy link
Contributor

Thanks @venkateshjo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility bug Something isn't working Component: Accordion Spectrum CSS Bug
Projects
None yet
Development

No branches or pull requests

5 participants