fix(color-area,color-slider): color-area labeling, RTL support, vertical slider orientation #3313 #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
added
bug
Tachometer resultsChromecolor-area permalink
color-slider permalink
color-wheel permalink
Firefoxcolor-area permalink
color-slider permalink
color-wheel permalink
|
| } | ||
|
|
||
| private handleFocusout(): void { | ||
| private handleBlur(): void { |
There was a problem hiding this comment.
I like the name change of these functions!
| this.addEventListener('focusin', this.handleFocusin); | ||
| this.addEventListener('focusout', this.handleFocusout); | ||
| this.addEventListener('focus', this.handleFocus); | ||
| this.addEventListener('blur', this.handleBlur); |
There was a problem hiding this comment.
I do worry about the API name change not being consistent with our other components, though. I think this is going in the right direction, but I feel like it would be good for me to confer with the rest of the team.
There was a problem hiding this comment.
The function name for these private methods can remain handleFocusin/handleFocusout, but we should listen for the focus and blur events in order to set the focused state properly.
1 task
najikahalsema
previously approved these changes
Jun 22, 2023
majornista
force-pushed
the
Issue-3313-ColorArea-a11y
branch
from
ccc62ab
to
c299401
Compare
…cal slider orientation #3313
majornista
force-pushed
the
Issue-3313-ColorArea-a11y
branch
from
c299401
to
5f1c3b5
Compare
najikahalsema
previously approved these changes
Jul 11, 2023
Westbrook
approved these changes
Jul 11, 2023
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.