fix(color-wheel): should reorient with dir="rtl" #3317 #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
added
bug
1 task
Tachometer resultsChromecolor-wheel permalink
Firefoxcolor-wheel permalink
|
hunterloftis
suggested changes
Jun 30, 2023
There was a problem hiding this comment.
@majornista thanks for putting this PR together. Could you add a test to verify that these RTL interactions work as expected?
majornista
force-pushed
the
3317-buga11yi18n-colorwheel-should-reorient-with-dir=rtl
branch
2 times, most recently
from
1003c09
to
1bc5ba2
Compare
|
@hunterloftis I think we already cover the interactions with https://github.com/adobe/spectrum-web-components/blob/ca2acdafe004cb962c00ebb7f79c5b6061dc6843/packages/color-wheel/test/color-wheel.test.ts#L261C2-L309C8 |
majornista
force-pushed
the
3317-buga11yi18n-colorwheel-should-reorient-with-dir=rtl
branch
from
f871549
to
41512f7
Compare
hunterloftis
previously approved these changes
Jul 12, 2023
hunterloftis
approved these changes
Jul 12, 2023
Westbrook
deleted the
3317-buga11yi18n-colorwheel-should-reorient-with-dir=rtl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.