Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add rows attribute to enable multiline Textarea with a predefined amount of visible lines #3331

Closed
1 task done
ingorichter opened this issue Jun 20, 2023 · 0 comments · Fixed by #3356
Closed
1 task done
Labels
enhancement New feature or request triage An issue needing triage

Comments

@ingorichter
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Textfield

Description of the requested feature

We are in the process to replace all react-spectrum with spectrum-web-component for the Share Dialog component. The Share Dialog uses a multiline Textarea with a predefined amount of rows. To replicate the current experience of the Share Dialog, we need a way to set the number of visible rows for the Textarea.

Mockups or screenshots

image

Implementation notes or ideas

The change would require to pass along the rows attribute to the underlying <textarea> and adjust the CSS to allow the textarea to grow to show the rows and to disable the resizing capability

@ingorichter ingorichter added enhancement New feature or request triage An issue needing triage labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant