Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GridController in @spectrum-web-components/grid missing 'lit' dependency #3486

Closed
1 task done
darthvadress opened this issue Jul 24, 2023 · 0 comments · Fixed by #3489
Closed
1 task done
Assignees
Labels
bug Something isn't working triage An issue needing triage

Comments

@darthvadress
Copy link

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

@spectrum-web-components/grid

Expected behavior

'lit' should be declared as a dependency for grid

Actual behavior

'lit' is not declared as a dependency for grid -

node_modules/.pnpm/@spectrum-web-components+grid@0.33.2/node_modules/@spectrum-web-components/grid/src/GridController.d.ts(1,41): error TS2307: Cannot find module 'lit' or its corresponding type declarations.

Screenshots

image

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@darthvadress darthvadress added bug Something isn't working triage An issue needing triage labels Jul 24, 2023
@Rajdeepc Rajdeepc self-assigned this Jul 25, 2023
@Rajdeepc Rajdeepc linked a pull request Jul 25, 2023 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants