feat(coachmark): rename "sp-coachmark" to "sp-coachmark-indicator", add "sp-coachmark" #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 8, 2023 17:02
Tachometer resultsChromeaction-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
button-group permalink
button permalink
card permalink
Firefoxaction-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
button-group permalink
button permalink
card permalink
|
added 8 commits
September 13, 2023 11:53
Rajdeepc
added
WIP
Component: Coach Mark
Needs discussion
1 task
|
@Westbrook coach indicator fixes are added in raised in #3958 |
I mistakenly reverted the coachmark css to the previous version. This is fixed now. |
|
Centering looks better on the default indicator, but the 
|
|
Font family is being applied wrong somewhere. This shouldn't have serifed body copy: |
@Westbrook It would be nice if both the alignment issue are fixed from the css side. I have left a note to them. 
|
Rajdeepc
force-pushed
the
feature/coachmark-new
branch
from
edd7dea
to
9866af8
Compare
Westbrook
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Taking a look at the font question, I think we could curcumvent any issue on our end by using:
:host {
--spectrum-coachmark-content-font-family: var(--spectrum-font-family);
}
In the case that we wanted to fast forward a fix and get this into a mergable state.
Westbrook
changed the title
|
LGTM. If you could catch up to |
Ready to land! |
… into feature/coachmark-new
Rajdeepc
force-pushed
the
feature/coachmark-new
branch
from
6eca3b4
to
75ceb99
Compare
Westbrook
reviewed
Feb 8, 2024
Westbrook
requested changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coach-Indicator and Coachmark[NEW] has been combined to be used in tandom.
Design: https://spectrum-contributions.corp.adobe.com/page/coach-mark-beta/
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.