fix: opacity checkerboard inclusion order #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README for the opacity-checkerboard class, to explain that this class should be included before component styles. And updates a wrong import path.
Make sure opacity checkerboard styles are included before the component styles, to make sure any component styles with the same specificity take precendence.
jawinn
force-pushed
the
checkerboard-inclusion-order
branch
from
88e43c6
to
5d791b0
Compare
Tachometer resultsChromecolor-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
swatch permalink
thumbnail permalink
Firefoxcolor-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
swatch permalink
thumbnail permalink
|
Westbrook
approved these changes
Sep 14, 2023
TarunAdobe
pushed a commit
that referenced
this pull request
Sep 20, 2023
* docs(opacity-checkerboard): update docs around inclusion order Update README for the opacity-checkerboard class, to explain that this class should be included before component styles. And updates a wrong import path. * fix(color-loupe): adjust inclusion order of opacity-checkerboard Make sure opacity checkerboard styles are included before the component styles, to make sure any component styles with the same specificity take precendence.
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to some discussion around an open issue around inclusion order in Spectrum CSS, and thoughts around doc updates when I was integrating opacity-checkerboard with ColorSlider.
How has this been tested?
Validation Steps
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.