Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-circle,toast,tooltip): ensure complete dependency graph #3701

Merged
merged 1 commit into from Oct 4, 2023

Conversation

Westbrook
Copy link
Collaborator

Description

Ensure availability of dependencies in a strictly managed package context.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Tachometer results

Chrome

progress-circle permalink

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 72.84ms - 73.75ms - unsure 🔍
-0% - +2%
-0.02ms - +1.30ms
branch 369 kB 72.18ms - 73.13ms unsure 🔍
-2% - +0%
-1.30ms - +0.02ms
-

toast permalink

Version Bytes Avg Time vs remote vs branch
npm latest 427 kB 73.69ms - 74.95ms - unsure 🔍
-1% - +2%
-0.59ms - +1.12ms
branch 422 kB 73.48ms - 74.63ms unsure 🔍
-2% - +1%
-1.12ms - +0.59ms
-

tooltip permalink

Version Bytes Avg Time vs remote vs branch
npm latest 556 kB 79.35ms - 80.73ms - unsure 🔍
-1% - +1%
-0.97ms - +0.81ms
branch 545 kB 79.56ms - 80.68ms unsure 🔍
-1% - +1%
-0.81ms - +0.97ms
-
Firefox

progress-circle permalink

Version Bytes Avg Time vs remote vs branch
npm latest 374 kB 172.51ms - 190.45ms - unsure 🔍
-10% - +4%
-19.36ms - +7.04ms
branch 369 kB 177.96ms - 197.32ms unsure 🔍
-4% - +11%
-7.04ms - +19.36ms
-

toast permalink

Version Bytes Avg Time vs remote vs branch
npm latest 427 kB 263.40ms - 289.28ms - unsure 🔍
-6% - +6%
-16.35ms - +17.71ms
branch 422 kB 264.58ms - 286.74ms unsure 🔍
-6% - +6%
-17.71ms - +16.35ms
-

tooltip permalink

Version Bytes Avg Time vs remote vs branch
npm latest 635 kB 249.55ms - 266.57ms - unsure 🔍
-2% - +6%
-4.71ms - +14.63ms
branch 629 kB 248.50ms - 257.70ms unsure 🔍
-6% - +2%
-14.63ms - +4.71ms
-

@najikahalsema najikahalsema merged commit a5dfada into main Oct 4, 2023
47 checks passed
@najikahalsema najikahalsema deleted the dep-graph branch October 4, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants