Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: sp-menu does not honor Numpad keys for Arrow ⬆️ ⬇️ and Enter #3751

Closed
1 task done
nija1993 opened this issue Oct 30, 2023 · 1 comment · Fixed by #4492
Closed
1 task done

[Bug]: sp-menu does not honor Numpad keys for Arrow ⬆️ ⬇️ and Enter #3751

nija1993 opened this issue Oct 30, 2023 · 1 comment · Fixed by #4492
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Spectrum Engineering

Comments

@nija1993
Copy link

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Menu

Expected behavior

Similar to how sp-menu supports navigating across with the help of keyboard arrow keys, it should also support Numpad arrow. Numpad Enter key also should work similar to the main Enter key.

Actual behavior

Numpad keys are not handled at all.

Screenshots

No response

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

  1. Go to storybook menu item page
  2. Click on the first menu item
  3. Using keyboard having numpad, use the ⬆️ ⬇️ keys of the numpad region
  4. Observe the active menu item doesn't change
  5. Press enter key from the numpad section
  6. Notice the menu item is not selected

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@nija1993 nija1993 added bug Something isn't working triage An issue needing triage labels Oct 30, 2023
@nija1993 nija1993 changed the title [Bug]: sp-menu does not honor Numpad keys for Arrow ↕️ and Enter [Bug]: sp-menu does not honor Numpad keys for Arrow ⬆️ ⬇️ and Enter Oct 30, 2023
@nija1993
Copy link
Author

nija1993 commented Nov 2, 2023

I can see the issue in https://github.com/adobe/spectrum-web-components/blob/main/packages/menu/src/Menu.ts, where instead of using event.code if event.key is used, this would be fixed.

@Westbrook Westbrook added good first issue Good for newcomers Spectrum Engineering enhancement New feature or request and removed triage An issue needing triage bug Something isn't working labels Jan 2, 2024
@nikkimk nikkimk linked a pull request May 23, 2024 that will close this issue
13 tasks
@nikkimk nikkimk removed a link to a pull request May 23, 2024
13 tasks
@nikkimk nikkimk linked a pull request May 23, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Spectrum Engineering
Projects
None yet
4 participants