fix(slider): high contrast improvements for filled track

[mdt2]

Description

• Uses Spectrum CSS Slider version 4.2.1

Related issue(s)

• Spectrum CSS PR 2325

Motivation and context

Add Windows High Contrast Mode improvements for sliders with a filled track.

How has this been tested?

• Test that Sliders are rendering correctly on the docs page
• Test that Sliders are rendering correctly in Storybook
• VRTs are passing

Screenshots

Before:

After:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Classic | Lightest | Medium | LTR
• Classic | Lightest | Medium | RTL
• Classic | Lightest | Large | LTR
• Classic | Lightest | Large | RTL
• Classic | Light | Medium | LTR
• Classic | Light | Medium | RTL
• Classic | Light | Large | LTR
• Classic | Light | Large | RTL
• Classic | Dark | Medium | LTR
• Classic | Dark | Medium | RTL
• Classic | Dark | Large | LTR
• Classic | Dark | Large | RTL
• Classic | Darkest | Medium | LTR
• Classic | Darkest | Medium | RTL
• Classic | Darkest | Large | LTR
• Classic | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL

[github-actions]

Tachometer results

Chrome

slider permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	480 kB	109.12ms - 111.16ms	-	unsure 🔍 -1% - +2% -0.87ms - +1.86ms
branch	472 kB	108.73ms - 110.56ms	unsure 🔍 -2% - +1% -1.86ms - +0.87ms	-

Firefox

slider permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	480 kB	219.68ms - 228.92ms	-	unsure 🔍 -2% - +3% -5.30ms - +7.34ms
branch	472 kB	218.97ms - 227.59ms	unsure 🔍 -3% - +2% -7.34ms - +5.30ms	-

[mdt2]

The failing VRTs in the Slider component are expected as part of the change.

[Westbrook]

Yep, the changes look like what I'd expect from you change. Can you take a look at this part of the docs to get the cache updated?

[mdt2]

@Westbrook thanks for that link! I updated the cache key, and after pushing realized I'm out of sync with main so I'll need to rebase, but before I do I'm now seeing that some Toast stories are removed in the VRTs which is definitely unexpected for this one. Any idea what could be causing that?

[Westbrook]

Any idea what could be causing that?

Sometimes failures cause failures in the VRTs and you need to update the cache value twice for it to go back to clean. Sadly.

[mdt2]

Sometimes failures cause failures in the VRTs and you need to update the cache value twice for it to go back to clean. Sadly.

Ok thanks. I'll move forward with updating the cache value to the new one

[Westbrook]

Sorry, I rebased this thinking it was ready to go, but we need to update to a non-beta release before we can merge. Keep an eye out for that when updating the version. After that, we should be good to go here. Thanks for taking care of this!

[Westbrook]

Have this gotten a full release?

[mdt2]

Not yet, on our side this work is pending re-review now that we've validated the changes here. I'll reach out to the team again to try to get some eyes on it.

[Westbrook]

Would love to get a stable release on this if we're ready.

[mdt2]

Would love to get a stable release on this if we're ready.

@Westbrook we were able to get this merged and released today and I've updated the PR with the new version 👍

[Westbrook]

Thanks for driving this home. Looking forward to including it in this week's release.