fix(overlay): leverage "transition-behavior" to persist top-layer content while closing #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalink
action-menu permalink
combobox permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-menu permalink
combobox permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
|
Westbrook
force-pushed
the
transition-behavior
branch
3 times, most recently
from
c258044
to
297a79b
Compare
Westbrook
force-pushed
the
transition-behavior
branch
5 times, most recently
from
169a032
to
82aab96
Compare
|
In FF (123.0), the lower (closed) picker renders over the upper (open) picker:
|
|
@hunterloftis this is expected as it falls outside of the support matrix of the polyfill we deliver the Overlay with when 
Do you think we should roll back that change in the demos? Firefox is tracking v125 support for |
Westbrook
force-pushed
the
transition-behavior
branch
from
e40923e
to
2957b84
Compare
|
@Westbrook ah I see, it's failing due to the backdrop filter. Personally I was thrown by the demo (it looked like a bug, rather than a demonstration of an edge case). I think it's fine to leave it as long as we make it clear that it's intending to demonstrate a cross-browser limitation. Naming it something other than "open," or putting text around the demo itself describing what it's showing. |
Westbrook
force-pushed
the
transition-behavior
branch
from
d83dec7
to
74c2152
Compare
Westbrook
force-pushed
the
transition-behavior
branch
from
74c2152
to
824fb67
Compare
hunterloftis
previously approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when the browser closers an Overlay for us, it will fall off of the
#top-layerimmediately and allow the Overlay content to paint behind standard page content while its close animation is playing.transition-behavior, in association with theoverlayproperty, allows the content to stay on the#top-layerthrough the course of the animation.TO DO
How has this been tested?
Types of changes
Checklist