fix(menu): correct disabled menu item's chevron to appropriate colour #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-menu permalink
combobox permalink
menu permalink
picker permalink
split-button permalink
Firefoxaction-menu permalink
combobox permalink
menu permalink
picker permalink
split-button permalink
|
Westbrook
pushed a commit
that referenced
this pull request
Feb 16, 2024
…#4052) * chore: add disabled submenu to submenu story * fix(menu): disabled menu chevron is now appropriate colour * ci: update hash --------- Co-authored-by: Najika Yoo <naj.halsema@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A local fix for this visual bug until Spectrum CSS is able to get back to fixing this for us. The chevron wasn't turning to the disabled colour if its menu item is disabled. Now, it does!
Related issue(s)
fixes #3659
Motivation and context
PSWeb fix request
How has this been tested?
Screenshots (if appropriate)
Before:
After (see Queens):
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.