You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.
The tachometer tests in https://github.com/adobe/spectrum-web-components/actions/runs/8172911409?pr=4141 are failing here in a way that I don't expect. Can you look into that? If you run them locally, and they still fail, opening the test link while it's attempting to run will allow you to see the error it encounters in the browser.
The tachometer tests in https://github.com/adobe/spectrum-web-components/actions/runs/8172911409?pr=4141 are failing here in a way that I don't expect. Can you look into that? If you run them locally, and they still fail, opening the test link while it's attempting to run will allow you to see the error it encounters in the browser.
Checked this and it is failing in local also with the below error clicking the test link. This is referring that it is not able to find the correct reference of "@spectrum-web-components/color-field/sp-color-field.js".
Error: bench-runner.html:1 Uncaught (in promise) TypeError: Failed to resolve module specifier "@spectrum-web-components/color-field/sp-color-field.js". Relative references must start with either "/", "./", or "../".
That likely means that we didn't get Color Field added to @spectrum-web-components/bundle appropriately. Can you check on including that in this PR?
I could see '@spectrum-web-components/color-field' in bundle/index.ts and elements.ts but it was missing as a dependency in @spectrum-web-components/bundle/package.json on its dependency tree
dependenciesPull requests that update a dependency file
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Westbrook
force-pushed
the
bug/color-field-dependency
branch
from
Description
Added missing dependencies in Color-Field
Also added
@spectrum-web-components/color-fieldin@spectrum-web-components/bundleRelated issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.