Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(truncated): add truncated package #4163

Merged
merged 7 commits into from Mar 8, 2024
Merged

fix(truncated): add truncated package #4163

merged 7 commits into from Mar 8, 2024

Conversation

AndreiBaicu26
Copy link
Contributor

To succesfully implement the Breadcrumbs component we would require the truncated element from UEC. We copied the component in SWC so we do not create a new dependency to UEC.

Related issue(s)

#4100

How has this been tested?

  • Test case 1
    1. Opened storybook
    2. Hover over truncated elements
    3. The tooltip appears.
  • Test case 2
    1. Opened storybook
    2. Hover over non-truncated elements
    3. The tooltip should not appear

Screenshots (if appropriate)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

github-actions bot commented Mar 8, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.97 0.97
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 242.657 kB 228.612 kB 🏆 228.678 kB
Scripts 61.209 kB 54.506 kB 54.475 kB 🏆
Stylesheet 48.901 kB 42.26 kB 🏆 42.321 kB
Document 5.835 kB 5.134 kB 🏆 5.17 kB
Third Party 126.712 kB 126.712 kB 126.712 kB

Request Count

Category Latest Main Branch
Total 43 43 43
Scripts 35 35 35
Stylesheet 5 5 5
Document 1 1 1
Third Party 2 2 2

@AndreiBaicu26 AndreiBaicu26 marked this pull request as ready for review March 8, 2024 10:08
Copy link

github-actions bot commented Mar 8, 2024

Tachometer results

Currently, no packages are changed by this PR...

@Westbrook Westbrook changed the title feat(truncated): add truncated tool fix(truncated): add truncated package Mar 8, 2024
@Westbrook Westbrook merged commit 4ba0480 into main Mar 8, 2024
49 checks passed
@Westbrook Westbrook deleted the abaicu/truncated branch March 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants