fix(number-field): handles values greater than 1000 #4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromenumber-field permalinkbasic-test
slider permalinktest-basic
Firefoxnumber-field permalinkbasic-test
slider permalinktest-basic
|
Westbrook
reviewed
May 8, 2024
Comment on lines
150
to
151
| describe('it handles values greater than 1000', () => { | ||
| it('correctly handles values greater than 1000 with step=1', async () => { |
There was a problem hiding this comment.
Can we bump this test up into the describe('Step', () => { block so we don't need the new describe, please.
There was a problem hiding this comment.
Corrected this on behalf of @blunteshwar.
Rajdeepc
approved these changes
May 8, 2024
Westbrook
approved these changes
May 8, 2024
Many thanks for the quick turn around on this.
|
Thanks for the fast fix! |
TarunAdobe
pushed a commit
that referenced
this pull request
May 10, 2024
* fix(number-field): handles values greater than 1000 * chore(number-field): updated tests --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where large numbers were being incorrectly formatted or rounded in the valueFormatter of the component. The problem was occurring due to the default behavior of the NumberFormatter which was using grouping for large numbers. This caused values greater than 1000 to be formatted incorrectly.
Changes Made:
Added the
useGrouping: falseoption to the NumberFormatter instantiation in the valueFormatter method.This change ensures that large numbers are formatted without grouping, preventing the rounding or truncation issues observed previously.
Related issue(s)
Motivation and context
This fix improves the accuracy of number formatting for large numbers in the component, ensuring that they are displayed correctly to the user.
How has this been tested?
Tested the fix with various large numbers and confirmed that they are now formatted correctly without any rounding or truncation.
Checked that the formatting behavior for numbers less than 1000 remains unchanged.
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.