Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Slider and Numberfield don't respect different locale with fractional steps #4483

Closed
1 task done
spdev3000 opened this issue May 22, 2024 · 1 comment · Fixed by #4508
Closed
1 task done

Comments

@spdev3000
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Slider, Numberfield

Expected behavior

When rendering an editable slider component or Numberfield with step=0.1 it should correctly increase/decrease the value by this step when using stepper buttons or key events (arrow up/down) - in all locales.

Actual behavior

When rendering an editable slider component or Numberfield with step=0.1 changing values by stepper button or key event works correctly in en-US locale, but doesn't in other locales (such as de-DE) where different characters are used as delimiter (, instead of .)

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://studio.webcomponents.dev/edit/3kPO18Pv4S4RTLAy6Pia/src/index.ts?p=stories
  2. Try adjusting the Numberfields in different locales with stepper or key events
  3. See different results for different locales, en-US is working well, de-DE isn't

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@spdev3000 spdev3000 added bug Something isn't working triage An issue needing triage Component: Slider Component: Number Field labels May 22, 2024
@najikahalsema najikahalsema added I18n and removed triage An issue needing triage labels May 22, 2024
@najikahalsema
Copy link
Collaborator

Fix your value formatter !!!!! @blunteshwar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants