Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading CSS custom properties into :root doesn't work for Edge #62

Closed
cuberoot opened this issue Jun 18, 2019 · 2 comments
Closed

Loading CSS custom properties into :root doesn't work for Edge #62

cuberoot opened this issue Jun 18, 2019 · 2 comments
Assignees
@cuberoot

Comments

@cuberoot
Copy link
Collaborator

Expected Behaviour

If we load the theme css into :root, it should be picked up by the web components

Actual Behaviour

On Edge, when I build with Webpack, for some reason Edge doesn't pick it up the variable that are injected into the <head> element.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Run the documentation server and look at it in Edge.

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem
@cuberoot cuberoot self-assigned this Jun 18, 2019
@cuberoot cuberoot mentioned this issue Jun 18, 2019
Merged
10 tasks
@benjamind
Copy link
Contributor

Should we document how to use the theme component here and close this out now?

@cuberoot
Copy link
Collaborator Author

cuberoot commented Aug 2, 2019

Yes, the theme component fixes this issue for us.

@cuberoot cuberoot closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuberoot cuberoot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuberoot @benjamind