Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Multimedia Support #166

Closed
rofe opened this issue Apr 22, 2020 · 12 comments
Closed

Multimedia Support #166

rofe opened this issue Apr 22, 2020 · 12 comments
Labels
batch-1 enhancement New feature or request

Comments

@rofe
Copy link
Contributor

rofe commented Apr 22, 2020

  • Support for Videos (youtube or AEM hosted)
  • Support for Slide Share
  • Support for Podcasts

@avanishgandhi to provide an existing example for each media type.

@rofe rofe added enhancement New feature or request batch-1 labels Apr 22, 2020
@avanishgandhi
Copy link
Collaborator

avanishgandhi commented Apr 23, 2020

Requested from the business teams.

My assumption here so that we want real examples and not nice to haves right?
If we use youtube and vimeo as video source for our videos.. we want sample of both types of videos as Helix platform will need to support embed code for both types of sources?

@rofe
Copy link
Contributor Author

rofe commented Apr 23, 2020

Yes, ideally examples of different media types used in theblog articles today.

@rofe
Copy link
Contributor Author

rofe commented Apr 27, 2020

@avanishgandhi thanks! Do you you also have an example of an "AEM hosted" video as mentioned in the description above?

@trieloff
Copy link
Contributor

Slideshare works in helix-embed: https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://www.slideshare.net/adobe/adobe-digital-insights-holiday-recap-2019?ref=https://cmo.adobe.com/

But we need to whitelist the URL pattern in helix-pipeline

@rofe
Copy link
Contributor Author

rofe commented Apr 28, 2020

YouTube, SlideShare and SoundCloud are all working now:
https://theblog-adobe.hlx.page/en/drafts/embed-test.html

@trieloff
Copy link
Contributor

@rofe could we set up a persistent browser based test for the embeds? They can break if:

  • any of the sites change their markup
  • iframely has a bug
  • helix-embed has a bug
  • helix-pipeline has a bug
  • word2md has a bug
  • an angry god just wants to see us suffer

@avanishgandhi
Copy link
Collaborator

@rofe I added AEM videos as i currently see videos on CMO Skyline instance of AEM. I asked Biz team and they could not recollect if they have used any of the videos from AEM. I am asking others to see if these video are ever referenced in articles

image

@avanishgandhi
Copy link
Collaborator

Can we also do Demo of User stories we complete? That we way we can show Biz team of the progress we are making.
thanks
Avanish

@rofe
Copy link
Contributor Author

rofe commented Apr 28, 2020

I am asking others to see if these video are ever referenced in articles

I remember there being a reference search in AEM Assets.

@rofe
Copy link
Contributor Author

rofe commented Apr 28, 2020

could we set up a persistent browser based test for the embeds?

If you give me a test page with examples of all supported embed types, I can set up the monitor script and automation in helix-embed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
batch-1 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants