Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

DOTCOM-25970 - in texts links lead to 404 (wrong link are rendered) #314

Closed
avanishgandhi opened this issue Jul 28, 2020 · 6 comments · Fixed by #324
Closed

DOTCOM-25970 - in texts links lead to 404 (wrong link are rendered) #314

avanishgandhi opened this issue Jul 28, 2020 · 6 comments · Fixed by #324
Assignees
Labels
batch-1 bug Something isn't working

Comments

@avanishgandhi
Copy link
Collaborator

JIRA - https://jira.corp.adobe.com/browse/DOTCOM-25970?src=confmacro

Detailed Description:
................................
URL:https://theblog.adobe.com/five-ways-make-sure-distributors-love-benefits-brand-portals-manufacturer-distributor-relationships/

https://blog.adobe.com/five-ways-make-sure-distributors-love-benefits-brand-portals-manufacturer-distributor-relationships/

The link goes to a wrong URL - https://blog.adobe.com/en/2017/06/06/www.adobe.com/marketing/target/product-recommendations.html which seems to be common to this URL

................................
Steps to Reproduce:

  1. click on digital asset management and product recommendations in text
    Expected Results:

Links go to new page
................................DOTCOM-25302
Actual Results:

404 error

@avanishgandhi avanishgandhi added batch-1 bug Something isn't working labels Jul 28, 2020
@rofe
Copy link
Contributor

rofe commented Aug 3, 2020

The links are wrong in the content: they are missing the https:// prefix and are therefore (correctly) treated as relative URLs by the browser...

Interestingly, the original blog post has a class auto-replaced on the anchor tag, so I assume WP auto-corrects such incomplete URLs on the fly, but I wouldn't recommend doing that. Depending on how common they are, I think we should fix them directly in the content. For future posts, we could try to detect and auto-correct them in the importer.

cc @kptdobe @davidnuescheler

@rofe
Copy link
Contributor

rofe commented Aug 3, 2020

Fixed the 2 broken links in the content and added an enhancement request to the importer project. Closing.

@rofe rofe closed this as completed Aug 3, 2020
@rofe
Copy link
Contributor

rofe commented Aug 3, 2020

Reopening after talking to @davidnuescheler: we will (also) fix them on the client side.

@rofe rofe reopened this Aug 3, 2020
@rofe rofe self-assigned this Aug 3, 2020
@trieloff
Copy link
Contributor

trieloff commented Aug 4, 2020

@rofe should the detection of "likely links" be something done in the pipeline? e.g.

[Example](www.example.com)

becomes

<a href=www.example.com" data-likely-href="https://www.example.com">Example</a>

so that we can override the href with data-likely-href either in helix-markup.yaml or in a short client-side script?

@rofe
Copy link
Contributor

rofe commented Aug 4, 2020

should the detection of "likely links" be something done in the pipeline?

I think that would be a nice feature.

@rofe
Copy link
Contributor

rofe commented Aug 4, 2020

Although in theblog, we can be "dumb" and always assume absolute URLs, whereas in the pipeline, we'll need to be smarter and account for all kinds of link types.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
batch-1 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants