Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-144254 [merch-card] per type heading map #2063

Merged
merged 2 commits into from
Apr 8, 2024
Merged

MWPW-144254 [merch-card] per type heading map #2063

merged 2 commits into from
Apr 8, 2024

Conversation

npeltier
Copy link
Contributor

@npeltier npeltier commented Mar 22, 2024 •
edited
Loading

introducing heading map once talked with Axel, that we can slowly grow to manage all card types.

Resolves: MWPW-144254

Test URLs:

@npeltier npeltier added run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer labels Mar 22, 2024
@npeltier npeltier requested a review from a team as a code owner March 22, 2024 06:08
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Mar 22, 2024 •
edited
Loading

Page Scores Audits Google
/docs/library/kitchen-sink/merch-card?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (94d3586) to head (e636ee6).

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #2063      +/-   ##
==========================================
+ Coverage   96.38%   96.40%   +0.01%     
==========================================
  Files         166      166              
  Lines       43448    43459      +11     
==========================================
+ Hits        41878    41895      +17     
+ Misses       1570     1564       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@afmicka afmicka added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Mar 29, 2024
@narcis-radu
Copy link
Contributor

@npeltier , @afmicka - this would be ready for stage, correct?

@afmicka
Copy link

afmicka commented Apr 1, 2024

@npeltier , @afmicka - this would be ready for stage, correct?

@narcis-radu yes, added the label

@Blainegunn Blainegunn merged commit efb196e into adobecom:stage Apr 8, 2024
17 checks passed
@Blainegunn Blainegunn mentioned this pull request Apr 8, 2024
Merged
@skumar09 skumar09 mentioned this pull request Apr 9, 2024
Merged
yesil pushed a commit to yesil/milo that referenced this pull request May 21, 2024
@npeltier @yesil
MWPW-144254 [merch-card] per type heading map (adobecom#2063)
5c31bd9 
* MWPW-144254 [merch-card] per type heading map

* optional chaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overmyheadandbody overmyheadandbody overmyheadandbody left review comments

@yesil yesil yesil approved these changes

@Axelcureno Axelcureno Axelcureno approved these changes

Assignees
No one assigned
Labels
commerce Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
7 participants
@npeltier @narcis-radu @afmicka @yesil @Axelcureno @overmyheadandbody @Blainegunn