Region selector #556
Merged
Region selector #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 94 94
Lines 25092 25092
=======================================
Hits 24050 24050
Misses 1042 1042 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
chrischrischris
approved these changes
Mar 15, 2023
| item.append(previewLink); | ||
| item.append(editLink); | ||
| li.append(item); | ||
| ol.append(li); |
There was a problem hiding this comment.
Nicer if results are alphabetized.
Using something like:
const insertAlphabetically = (ol, li) => {
const locale = li.getAttribute('data-locale');
const items = [...ol.getElementsByTagName('li')];
const insertBefore = items.find((item) => locale < item.getAttribute('data-locale'));
if (insertBefore) {
ol.insertBefore(li, insertBefore);
} else {
ol.append(li);
}
};
Suggested change
| ol.append(li); | |
| insertAlphabetically(ol, li); |
There was a problem hiding this comment.
Thanks for the tip. Applied!
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
|
|
|
|
|
rgclayton
approved these changes
Mar 17, 2023
|
|
|
auniverseaway
approved these changes
Mar 17, 2023
rgclayton
approved these changes
Mar 17, 2023
|
|
chrischrischris
added a commit
to adobecom/milo-target
that referenced
this pull request
May 22, 2023
* Adding tool button.
* WIP
* wip
* for testing.
* For testing
* Fixing few stuff after testing.
* Adjust palette size, change div to ol
* Sort the locale array alphabetically.
* nit: little refactoring.
* UI/UX update.
* remove white bg
* Added guide line for each item
* Fail condition added.
* Update libs/blocks/region-selector-loader/region-selector-loader.js
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
* Print result alphabetically.
* nit: update getAttribute('data-locale') to dataset.locale
* Color code added for un-previewed webPath.
* Updated style as Rikkio and Ryan agreed.
* Taking off the test code.
* UI/UX update and enabling it on pages as well.
* Renaming the block
* Taking off the test urls
* Added search.
* Matching the search bar size as icons.
* Fixed the set logic.
* Polish (adobecom#575)
* Fix security issue
* Fix security issue
---------
Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Co-authored-by: Chris Millar <cmillar@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-127468
Test URLs:
Word Referrer (edit mode)
Page Referrer (view mode)